Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thicken normal incorrect #623

Open
MatthiasJ1 opened this issue May 9, 2024 · 2 comments
Open

Thicken normal incorrect #623

MatthiasJ1 opened this issue May 9, 2024 · 2 comments

Comments

@MatthiasJ1
Copy link
Contributor

l1 = JernArc((0,0), (-1,0), 1, 180).edge().reversed()
l2 = JernArc((0,0), (1,0), 2, -90)
s = RadiusArc((0,0), (0,-1), 1)
f = sweep((l1^0)*s, l1) + sweep((l2^0)*s, l2) # Workaround for #622
1
p = thicken(f, 0.4)
2
@gumyr
Copy link
Owner

gumyr commented May 10, 2024

There is a normal_override parameter of thicken to help cope with these situations:

p = thicken(f, 0.4, normal_override=(0, 1, 0))

image

When thicken was developed controlling the normal was found to be difficult so this override was added as the best solution at the time.

@MatthiasJ1
Copy link
Contributor Author

Shouldn't it just thicken in the face normal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants