Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making "File settings" options global #2212

Open
4 tasks done
elyahw opened this issue Feb 6, 2024 · 6 comments
Open
4 tasks done

Consider making "File settings" options global #2212

elyahw opened this issue Feb 6, 2024 · 6 comments

Comments

@elyahw
Copy link

elyahw commented Feb 6, 2024

⚠️ This issue respects the following points: ⚠️

  • This is a enhancement/feature request. Not a bug or question.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The wanted feature/enhancement is not present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor's settings are not touched. If your desired feature is present, you don't need to open this issue. The change will be part of the next Markor update.)

Description

  1. Currently if you open a note, press '...' on the top right corner, then "File settings", there are many useful options such as: "Wrap words", "Line numbers", "Syntax highlighting", "Font size".
  2. They are very useful options. Some of them are disabled by default such as "Line numbers", which is particularly useful to me, and which I have to enable it manually on many individual files.
  3. Why not move these options to the global settings so that they are applied to a certain extension?

Advantages:

  1. It will declutter the main interface, and move 4 buttons to the settings. Therefore simplifying the main interface. Perhaps consider then reshuffling the '...' menu?
  2. All four options I quoted are very useful that it should be possible to set them globally, not individually.

Information

Android version: 13
Device: Pixel 5a
App Version: 2.11.1

Source

GitHub Releases

Format / File type

Not specific

Additional info / Log

-
@gsantner
Copy link
Owner

gsantner commented Feb 6, 2024

You can find the default setting in the normal settings menu, i.e. under Editor section. That should be the case for the majority.

@guanglinn
Copy link
Contributor

guanglinn commented Feb 7, 2024

@elyahw , I basically agree with your opinions. Such as Line numbers, I also think it should have a global setting, and this option initially did support global settings, you can see this PR.

@elyahw
Copy link
Author

elyahw commented Feb 7, 2024

Thanks. @gsantner But there are no global options for "Line numbers" and "Syntax highlighting".

I suggest to add these two options to the rest of global settings, and perhaps remove the file-specific ones; this will simplify the app.

Right now I think it has too many options that can be accessed from different places, therefore it is confusing for the new user.

@harshad1
Copy link
Collaborator

The way we do this for other cases is have a global default for new files and have the per-file setting which overrides this if toggled.

I think such a global default option for syntax highlighting and line numbers is a good idea

@elyahw
Copy link
Author

elyahw commented Feb 10, 2024

Yes. I have been thinking about it. I think the per-file settings should be removed. Why?

  1. Why not use a different extension and enable line numbers on that extension only. This is a simple solution.
  2. It over complicates things: There are many extensions and each comes with a default set of settings. I have 100s of notes on my phone I keep deleting/cutting/pasting them into each other. There is no way I can track the settings for an individual note. Using the global settings for this purpose is a peace of mind.

@gsantner
Copy link
Owner

gsantner commented Feb 16, 2024

I would also like to simplify it a bit, from my view - only make two pairs of global settings for the majority. Which is for files in normal editor/viewer, and for the other part how it appears on the main screen (QuickNote/todo). You want less bloat there, i.e. no line numbers or alike.

What can't be global and at the end is (or should be) really file specific are things like BOM and file encryption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants