notify the user that we only overwrite text with length >=2

[XYIheng]

⚠️ This issue respects the following points: ⚠️

• This is a bug. Not a question or feature request.
• The topic is not already reported at Issues. (I've searched it).
• Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
• The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

I created a file named "A.md" with content "A". Then I click FAB to create "A.md" again. Markor doesn't redirect" to the existing file and just creates a new A.md with empty content.
It only happens when the length of the content equals 1.

Steps to reproduce

1. Create a file named "A.md" with content "A"
2. Back to file list
3. Click FAB to create a file with the same name "A.md"
4. See the error: markor shows empty content rather than redirect to the existing file

Information

Android version: 8
Device:
App Version: 2.11.1

Source

F-Droid

Format / File type

Not specific

Additional info / Log

- a relevant bug report https://github.com/gsantner/markor/issues/994

[harshad1]

This is an explicit decision:

https://github.com/gsantner/markor/blob/master/app/src/main/java/net/gsantner/opoc/util/GsContextUtils.java#L2273C99-L2273C99

https://github.com/gsantner/markor/blob/master/app/src/main/java/net/gsantner/opoc/util/GsContextUtils.java#L192

public static int TEXTFILE_OVERWRITE_MIN_TEXT_LENGTH = 2;

Not sure why we do this (but usually @gsantner has a good reason)

[XYIheng]

@harshad1 Thanks for the explanation!

[XYIheng]

It seems weird. Maybe it's better to overwrite text length >=1. Or we should give a hint to notify the user that we only overwrite text with length >=2

[gsantner]

Making a Toast.LENGTH_SHORT would be a option, when this non saving case triggers.

You can reach the ~1-2 chars by i.e. \n / \r\n. If you really want to clear out a file you always have the save button to explicitly save a empty document. OR the option to delete the file as a whole.