Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileBrowser: File Modification Time not updated until app restart #2196

Open
4 tasks done
XYIheng opened this issue Jan 3, 2024 · 4 comments · Fixed by #1992
Open
4 tasks done

FileBrowser: File Modification Time not updated until app restart #2196

XYIheng opened this issue Jan 3, 2024 · 4 comments · Fixed by #1992
Labels

Comments

@XYIheng
Copy link

XYIheng commented Jan 3, 2024

⚠️ This issue respects the following points: ⚠️

  • This is a bug. Not a question or feature request.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

Modifying a file does not update its modification time immediately.
Refresh file list also not work.
The file's modification time remains unchanged until the application is restarted.

Steps to reproduce

  1. open an existing file
  2. edit it
  3. close
  4. see the error: file modification time does not change
bug_file_modification_time.mp4

Information

Android version: 8
Device: pixel2
App Version: 2.11.1

Source

F-Droid

Format / File type

Not specific

Additional info / Log

-
@gsantner
Copy link
Owner

@XYIheng Can you try a APK you can find on any of the development builds here https://github.com/gsantner/markor/actions? As the file metadata caching was reworked this should not be case in the master branch anymore.

@gsantner gsantner linked a pull request Jan 11, 2024 that will close this issue
@XYIheng
Copy link
Author

XYIheng commented Jan 18, 2024

@gsantner Hi, it still does not work for me. I try the apk here https://github.com/gsantner/markor/actions/runs/7493416005.
The file's modification time remains unchanged until the application is restarted.

@gsantner gsantner reopened this Feb 16, 2024
@gsantner gsantner changed the title Bug : File Modification Time Does Not Update Immediately After Editing Until App Restart FileBrowser: File Modification Time not updated until app restart Feb 16, 2024
@gsantner gsantner added the bug label Feb 16, 2024
@guanglinn
Copy link
Contributor

@gsantner We should call notifyItemChanged(position) or notifyDataSetChanged() after some files were modified.

@gsantner
Copy link
Owner

On pull down reload we also do that as far I know. But the info might be cached somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants