Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about the ancestors (or ascendants) of a component? How would it be? #5

Open
giovannipds opened this issue Jan 20, 2016 · 2 comments

Comments

@giovannipds
Copy link

Hello man!

First of all, great compilation, congratulations for your efforts. I also really like styleguides, rules, like yours.

I was thinking of a case today which it may be interesting of debating it with you. What about a case where my component is like, a ribbon. You know, in the corner of an element. I was thinking in some markup like this:

<div class="ribbon-container">
    <div class="ribbon">New</div>
    <h1>Etc...</h1>
    <p>Lorem ipsum dolor sit amet.</p>
</div>

In this case, the ribbon-container is an ancestor/ascendant of the component, and not a descendant. How would you suggest it to be marked up? ribbon-container? ribbon__container? I never read too much about BEM and this kind of suggestions so if you know something about it, it would be interesting listening to you.

Happy to contribute somehow. My best wishes. Regards, Gio. Oh, by the way, I'm also a brazilian, so if you'd prefer to discuss it in portuguese, feel free to do that.

@grvcoelho
Copy link
Owner

Hi 😄 How I would do it:

  1. Calling .ribbon__container is not ideal because the container is not a descendant of .ribbon. I would call it .ribbon-container as well.

  2. Keep .ribbon-container in the same file as the rest of the .ribbon definition. Something like ribbons.sass, for example.

@giovannipds
Copy link
Author

Hello. That's exactly what I did. 😄

What you think of including this case to your repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants