Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream console logger to jshint #154

Open
jzaefferer opened this issue Mar 24, 2014 · 2 comments
Open

Upstream console logger to jshint #154

jzaefferer opened this issue Mar 24, 2014 · 2 comments

Comments

@jzaefferer
Copy link
Member

One big strength of this plugin over using jshint directly is the console logger. Compare this:

sublimedemo.js: line 4, col 6, 'x' is defined but never used.

with

Linting sublimedemo.js ...ERROR
[L4:C6] W098: 'x' is defined but never used.
var x =1;

The above lacks the colored output this plugin actually provides, which also helps with the readability.

I don't yet know if there's any interest on the end of jshint, but I think we should at least try to upstream this logging implementation to make it available to all users of jshint, not just users of this plugin.

Looks to me like the relevant code is mostly this part in tasks/lib/jshint.js

@vladikoff
Copy link
Member

Hey @jzaefferer is this issue for us or for JSHint?

@jzaefferer
Copy link
Member Author

@vladikoff well, eventually. It seems like the best approach would be for one the contributors on this project to put together a pull request for JSHint, since that should avoid any copyright issues. That way we can keep track of that PR and update this plugin when the JSHint output matches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants