Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: application factory pattern for db connection #106

Open
grumpyp opened this issue Jul 25, 2023 · 2 comments
Open

refactor: application factory pattern for db connection #106

grumpyp opened this issue Jul 25, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@grumpyp
Copy link
Owner

grumpyp commented Jul 25, 2023

While building #81 I saw that our current version of AIxplora sets up a new DB connection on every request.

That's not best practise and should be replaced.

First impressions on a solution:
https://stackoverflow.com/questions/63270196/how-to-do-persistent-database-connection-in-fastapi

I am open to any other solution which is better than the current implementation.
@grumpyp grumpyp added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 25, 2023
@Sadaf-A
Copy link

Sadaf-A commented Aug 4, 2023

Greetings! @grumpyp I would like to work on this

@Sadaf-A
Copy link

Sadaf-A commented Aug 4, 2023

@grumpyp #109 I've opened this PR please have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grumpyp @Sadaf-A