-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP Basics tutorial has multiple issues #1274
Comments
@stanley-cheung Please take a look |
Thanks for logging this issue. Yea the php example is outdated. On the suggestion, I think we should just link to the grpc/grpc-node repo instead of copying any code. (i.e. update the instruction to say "use grpc/grpc-node in this way") |
Yeah, this sounds better. I'll make a PR for these changes next week to get the ball rolling! |
There are multiple issues with https://grpc.io/docs/languages/php/basics/.
Instructions to build
grpc_php_plugin
appear to be outdated.This section produces an error:
The script errors:
Instead, the instructions should say to use bazel as in grpc/grpc#25350 (comment):
The node server has moved
This section produces an error:
nmp install
errors:This is because the package.json is just a string:
I'd suggest simply linking to https://github.com/grpc/grpc-node/tree/master/examples/routeguide but there are no instructions there for running the route guide example. So perhaps it would be better to give people specific instructions to run the node server inside the php examples directory:
Note that the current instructions have the
node
command incorrectly written asnodejs
:Client script fails
eventually hits this error:
This is because:
Pointing
run_route_guide_client.sh
to./grpc-node/examples/routeguide/static_codegen/route_guide_db.json
fixes the issue.Fix
I'd be happy to make a PR to fix these instructions if there's agreement that cloning
grpc-node
into theexamples/php/route_guide
directory makes sense.The text was updated successfully, but these errors were encountered: