-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
credentials
parameter not implemented/unused when generating grpc-web code
#1387
Comments
me too. |
@Manuelraa Thanks so much for filing a detailed bug, with a repo for reproducing as well! I think you're indeed right that the I don't have all the history of the project, but from what i can see, even from the very early versions of the generator code (example) , the @stanley-cheung Hey Stanley I wonder if you have some background on the |
When compiling grpc-web code the generated client's
credentials
argument is unused.Therefore I have to manually provide credentials in request metadata.
Example/Reproduced in this repo: https://github.com/Manuelraa/grpc_web_creds_bug
Files
Example proto
Dockerfile for generation
generate script
Code generation and the problem
Generating files
Checking the generated code
Then checking the generated
test_grpc_web_pb.js
file we see thecredentials
parameter is not handled.The text was updated successfully, but these errors were encountered: