New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds: support LRS for all cluster types #7192
Comments
For aggregate clusters, all configuration comes from the underlying clusters, including LRS. https://github.com/grpc/proposal/blob/master/A75-xds-aggregate-cluster-behavior-fixes.md contains the latest spec on how aggregate clusters should work. A74 is related as well. |
@easwars shall we close this? I see the related PR is merged |
That PR does not handle the issue mentioned in here. That PR only adds server config to the |
Let me know if you think it could be good task for me to look at |
When working on #7191, I realized that we were setting the LRS server configuration only for EDS clusters. This needs to be supported for all cluster types.
Note that for non-EDS cluster types, there is no locality info, so we default to reporting everything in a single locality name with all fields set to the empty string.
We need to also ensure that we have proper e2e test coverage for all supported cluster types.
The text was updated successfully, but these errors were encountered: