Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: support LRS for all cluster types #7192

Open
easwars opened this issue May 6, 2024 · 4 comments
Open

xds: support LRS for all cluster types #7192

easwars opened this issue May 6, 2024 · 4 comments
Assignees

Comments

@easwars
Copy link
Contributor

easwars commented May 6, 2024

When working on #7191, I realized that we were setting the LRS server configuration only for EDS clusters. This needs to be supported for all cluster types.

Note that for non-EDS cluster types, there is no locality info, so we default to reporting everything in a single locality name with all fields set to the empty string.

We need to also ensure that we have proper e2e test coverage for all supported cluster types.

@dfawley dfawley added the P2 label May 7, 2024
@easwars
Copy link
Contributor Author

easwars commented May 8, 2024

For aggregate clusters, all configuration comes from the underlying clusters, including LRS.

https://github.com/grpc/proposal/blob/master/A75-xds-aggregate-cluster-behavior-fixes.md contains the latest spec on how aggregate clusters should work. A74 is related as well.

@purnesh42H
Copy link
Collaborator

@easwars shall we close this? I see the related PR is merged

@easwars
Copy link
Contributor Author

easwars commented May 9, 2024

That PR does not handle the issue mentioned in here. That PR only adds server config to the ClusterUpdate struct (this work was not done as part of A47, but is required for A71). This issue needs to stay open.

@purnesh42H
Copy link
Collaborator

That PR does not handle the issue mentioned in here. That PR only adds server config to the ClusterUpdate struct (this work was not done as part of A47, but is required for A71). This issue needs to stay open.

Let me know if you think it could be good task for me to look at

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants