Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable "Select All" overwrites previously selected #6946

Open
LiveFreeAndRoam opened this issue Sep 15, 2023 · 1 comment · May be fixed by #6973
Open

DataTable "Select All" overwrites previously selected #6946

LiveFreeAndRoam opened this issue Sep 15, 2023 · 1 comment · May be fixed by #6973
Labels
bug issue that does not match design or documentation and requires code changes to address Data and friends For data components in grommet discussion Needs deeper discussions

Comments

@LiveFreeAndRoam
Copy link

Expected Behavior

"Select All" should extend the currently selected set with newly selected. This behaviour is observed when selecting individual rows, so should be the same when selecting all rows.

Actual Behavior

"Select All" replaces the currently selected set.

URL, screen shot, or Codepen exhibiting the issue

https://codesandbox.io/s/grommet-filtered-datatable-3b37fe?file=/src/App.js

Steps to Reproduce

  1. Go to the URL above

  2. Select the first row in the table
    image

  3. Search for "CCCC" to get a disjoint set
    image

  4. Check "Select All" (overwrites currently selected)
    image

Compare that with selecting individual rows. In this case the selections are additive.
image### Your Environment
image

  • Grommet version:
  • Browser Name and version:
  • Operating System and version (desktop or mobile):
@halocline halocline added bug issue that does not match design or documentation and requires code changes to address Data and friends For data components in grommet labels Sep 15, 2023
@HardikChoudhary24 HardikChoudhary24 linked a pull request Oct 15, 2023 that will close this issue
Open
4 tasks
@halocline halocline added the discussion Needs deeper discussions label Nov 2, 2023
@taysea
Copy link
Collaborator

taysea commented Nov 29, 2023

To advance this, we need to gather more data. Currently blocked until we have that environment set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug issue that does not match design or documentation and requires code changes to address Data and friends For data components in grommet discussion Needs deeper discussions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DataTable 'Select All' does not overwrites previously selected HardikChoudhary24/grommet
3 participants
@halocline @LiveFreeAndRoam @taysea