Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-visit approach to DataTable theme header, body, footer background. #145

Open
1 task
halocline opened this issue Dec 3, 2020 · 0 comments
Open
1 task

Re-visit approach to DataTable theme header, body, footer background. #145

halocline opened this issue Dec 3, 2020 · 0 comments
Labels
bug Something isn't working
Projects
Grommet/Design System Backlog

Comments

@halocline
Copy link
Collaborator

halocline commented Dec 3, 2020 •
edited

Matt reported that the DataTable footer now has a default background color (I believe header does as well) but body does not.

For consistency, I believe we should be setting consistent default backgrounds in the theme across header, body, footer, which then can be tailored with the background prop.

  • Follow up with Matt Muggeridge with findings / decided direction.
@halocline halocline transferred this issue from grommet/hpe-design-system Dec 3, 2020
@halocline halocline changed the title Re-visit approach to DataTable theme header, footer, background. Re-visit approach to DataTable theme header, body, footer background. Dec 3, 2020
@ericsoderberghp ericsoderberghp mentioned this issue Dec 4, 2020
Merged
@ericsoderberghp ericsoderberghp added the bug Something isn't working label Dec 7, 2020
@ericsoderberghp ericsoderberghp moved this from Triage to To do in Grommet/Design System Backlog Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Grommet/Design System Backlog
  
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@halocline @ericsoderberghp