Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uniprot IDs to MyGene.info box #1342

Closed
kkrysiak opened this issue Mar 26, 2020 · 6 comments · Fixed by #1344 or #1532
Closed

Add uniprot IDs to MyGene.info box #1342

kkrysiak opened this issue Mar 26, 2020 · 6 comments · Fixed by #1344 or #1532

Comments

@kkrysiak
Copy link
Contributor

Probably in the pop up, and not necessarily in the main box.

@susannasiebert susannasiebert added this to Open in v1 Enhancements via automation Mar 26, 2020
@susannasiebert susannasiebert moved this from Open to 1.5 Paper in v1 Enhancements Mar 26, 2020
@malachig
Copy link
Member

Text from Peter McGarvey:

However, nothing will get implemented on our side until CIViC has links back to UniProt entries for each protein encoding gene and we have an example mapping file. So we will need you to work on these sometime. You mentioned before about using mygeneinfo to link back to UniProt and that is fine, their mapping to us are good and I would suggest you only take the SwissProt accessions. If you could add a link to us in the blue mygeneinfo box on your gene pages that would be perfect, though you could put it elsewhere on the page if you want.

We also need you to provide us with a tab delimited mapping file with the uniprot accession and the identifier we use to link to you. In the examples you mentioned this would be either the gene symbol "BRAF" or "5". Personally I think BRAF is best. So it might look like.

P15056 BRAF
Q9UM73 ALK
.....

If there is a url to your APIs that can produce a tab delimited list like this we can use that also. We have too many xrefs to process to maintain parsers to different formats various resources use so we ask for an ftp or http(s) link to get or create the file.

@malachig
Copy link
Member

Also from Peter,

Note: there is an option for a third string of information where the "-" is. If CIViC wanted to use this it might add something like "45 variants" or similar info each gene. Requires a 3rd column in the tab delimited table.

So perhaps we could do something similar to what we do for NDEX. Where a process runs on a schedule to produce this tab delimited file that will be hosted from the CIViC server and used for uniprot to do their updates. The file would be a TSV with three columns: uniprot id, gene name, basic stats about civic info on the gene.

@susannasiebert susannasiebert moved this from 1.5 Paper to Waiting on Code Review in v1 Enhancements Apr 2, 2020
v1 Enhancements automation moved this from Waiting on Code Review to Done Apr 9, 2020
@malachig
Copy link
Member

malachig commented Sep 29, 2020

Peter McGarvey followed up with me on this today. I believe this is done now from our end?

Screen Shot 2020-09-29 at 2 49 03 PM

@malachig
Copy link
Member

One of the requirements mentioned above is:

We also need you to provide us with a tab delimited mapping file with the uniprot accession and the identifier we use to link to you. In the examples you mentioned this would be either the gene symbol "BRAF" or "5". Personally I think BRAF is best. So it might look like.

P15056 BRAF
Q9UM73 ALK

If there is a url to your APIs that can produce a tab delimited list like this we can use that also. We have too many xrefs to process to maintain parsers to different formats various resources use so we ask for an ftp or http(s) link to get or create the file.

Was that handled or does the capability to generate this readily via API already exist?

@malachig
Copy link
Member

I realize this is contradicting the original comment on this issue, but can we also put the UniPROT ID in the main blue gene info box? Right beside Entrez ID?

@malachig malachig reopened this Sep 29, 2020
v1 Enhancements automation moved this from Done to Open Sep 29, 2020
@susannasiebert
Copy link
Contributor

I made a new issue for creating the mapping file: #1533

v1 Enhancements automation moved this from Open to Done Nov 5, 2020
@susannasiebert susannasiebert moved this from Done to Staged in v1 Enhancements Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
v1 Enhancements
  
Staged
3 participants