Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI improvements #13

Open
greengiraffe opened this issue Dec 22, 2020 · 0 comments
Open

Minor UI improvements #13

greengiraffe opened this issue Dec 22, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@greengiraffe
Copy link
Owner

I only have a few tiny suggestions for 'improvement', take them as you wish:

  • for the new Nectar row, would be nice to somehow indicate it only
    applies to the Oceania expansion. I don't think the row should show/hide,
    just if someone only has the base game, they might wonder "What's Nectar?
    What am I missing?"
  • in my fork, I reduced the left/right margins and padding as much as
    possible, and squeezed the left column slightly to give maximum space for
    the names. With 5 players, on a phone screen, it's a little cramped
  • on a phone-width screen (I use Chome's DevTools device toolbar, my
    phone display is closest to 'Pixel 2' size), on the bottom line, there's an
    unfortunate line-break in the middle of "Nils Cordes"

[image: image.png]

On Tue, Dec 22, 2020 at 11:45 AM Valentin von Guttenberg <
[email protected]> wrote:

Fixed. Used a wrong compare function for sorting the scores.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARGAKDQ7DFOKFZLH5NYH7PLSWDEI7ANCNFSM4URLZ42Q
.

Originally posted by @verdantPermission in #10 (comment)

@greengiraffe greengiraffe added the enhancement New feature or request label Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant