-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: OAuth fails for Azure AD external users due to #
in user id
#2773
Labels
bug
Something isn't working
Comments
nazarewk
added a commit
to nazarewk/netmaker
that referenced
this issue
Jan 19, 2024
nazarewk
added a commit
to nazarewk/netmaker
that referenced
this issue
Jan 19, 2024
nazarewk
added a commit
to nazarewk/netmaker
that referenced
this issue
Jan 19, 2024
nazarewk
added a commit
to nazarewk/netmaker
that referenced
this issue
Jan 19, 2024
nazarewk
added a commit
to nazarewk/netmaker
that referenced
this issue
Jan 19, 2024
actually it is a lot more than just a
|
nazarewk
added a commit
to nazarewk/netmaker
that referenced
this issue
Jan 22, 2024
nazarewk
added a commit
to nazarewk/netmaker
that referenced
this issue
Jan 23, 2024
nazarewk
added a commit
to nazarewk/netmaker
that referenced
this issue
Jan 23, 2024
nazarewk
added a commit
to nazarewk/netmaker
that referenced
this issue
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
Azure AD external users are in format:
user.name_external.domain.com#EXT#@internaltenant.onmicrosoft.com
for user[email protected]
andinternaltenant
, which does not pass the internal check due to presence of#
:netmaker/models/structs.go
Lines 274 to 282 in 630c95c
Version
v0.22.0
What OS are you using?
Linux
Relevant log output
[netmaker] 2024-01-18 09:45:56 error creating user, krzysztof.nazarewski_[REDACTED].com#EXT#@[REDACTED].onmicrosoft.com ; user not added
Contributing guidelines
The text was updated successfully, but these errors were encountered: