New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lsp-server] 🐞 Error: Cannot find module 'astrojs-compiler-sync' #3516
Comments
@M1CK431 oh noo... i manually tested with vscode-graphql vsix and everything! |
I'm using Open VSX as extensions marketplace, don't know if it may have an impact or not 🤷🏼♂️ Also, I try to uninstall / reinstall => same issue 😢 |
huh, are you using it with astro files? i cannot reproduce it from the vscode marketplace. i will try again after work it might be an issue that only effects the ovsx bundle and not the vsix bundle. sadly both can only be manually tested 🥺 |
I haven't any astro file in my projet (in fact I even don't know what it is 🤭). Perhaps there is an extra check to do on |
Extra info: I'm using Code OSS, again dunno if it may have any impact. |
I'm also experiencing this error on v0.9.1 [Error - 11:48:13] vscode-graphql client: couldn't create connection to server. Error: Cannot find module 'astrojs-compiler-sync'
|
Having the same problem, from a cursory inspection it seems this only manifest in situation where the LSP server is ran with a plain nodejs runtime (v18.15.0) rather than the bundled Electron runtime. This happens as well when you are using the remote extensions (e.g. SSH). TL;DR I would bet the problem is that nodejs is trying to load code/modules differently from how Electron does it when running locally with the official distribution. |
Last week I upgraded Regarding running the LSP outside of an IDE client build - It is marked as a dependency of the |
@acao are you speaking about v0.9.1? If yes, I already try it and experiencing the same issue. Also, if my |
Having same issue in MacOS:
|
I also have the same issue, but currently I can work around it by running cd ~/.vscode-oss/extensions/graphql.vscode-graphql-0.9.1-universal/
npm install
|
Confirmed this workaround to works from my side too. I use |
Same issue here with Code OSS on Manjaro with
I'm using Astro but without GraphQL. However I have both extensions enabled globally. The strange thing is that the output of the Developer Tools (
Then:
Then:
Then:
Then:
Then the errors repeat themselves since the server cannot be restarted and finally I get:
|
98af530#diff-282a02f8ecaf263e63ceecdc0702ec641f159a3b9069ad12769816236f0f602e I believe the "external" params is preventing astro from being installed. |
unfortunately, if we remove it from |
if you're still experiencing this bug in the latest release of the vscode extension or the CLI, let's do a poll - please react to this comment with:
|
Solved in #3547 🥳 |
fantastic to hear, thanks for helping! |
@M1CK431 Looks like the fixed version was not published to open vsx, there the latest version is still |
@Csszabi98 That's true but your man is @acao , not me 😉 |
@Csszabi98 I think there is an issue with openvsx publishing again and I will check to restore this before the next release! |
i will keep this open until we can confirm there is a working release for Open VSX users i also released a prerelease of 0.10 to openvsx manually, as i did for vscode marketplace. did those show up? huge improvements coming across the board! |
ok, so, i learned the hard way that the bundled extension approach for open vsx publishing that appears to fix this issue also does not support pre-release. due to this and another issue I have accidentally published 0.10.1 pre-release as 0.10.1 stable on open-vsx 😆. an accidental bonus, you'll be seeing a fix for this issue as well as many other bugfixes, i apologize if there are any bugs from this refactor that you see before marketplace users do, but we can get this all cleaned up in a few patch releases to both extensions. unfortunately vsix extensions do not support full semver for pre-releases, so it's tricky to get them working with our release tooling, as it could cause many undesired version increments if we're not careful |
ok so, the bad news is that 0.10.1 turned out to be a not-good release for schema first users on manual testing because of some assumptions by the integration test suites that didn't pan out. i can't find a way to roll back on openvsx either. i will find a way to rectify this, but i hope to ideally have an 0.9.4 release if I can or an 0.10.2 release to fix this, without the rewrite that currently needs some more tweaking |
I have asked the eclipse foundation to delete the impacted versions from the registry until we can correct this! Emoji reacts might help boost it :) if they aren't able to get back to me by monday, i will just jump the 0.10.x release for 0.11, and make 0.10.2 the fix for all open-vsx users with a matching repeat release for the marketplace just so we're back in sync |
I just add a 👍🏼 on the mentioned issue 😘 |
ok! those versions are deleted. partially resolved. I will try to get you a 0.9.4 release to fix tomorrow, and we will keep trying til it does. probably high time i install vscodium and confirm it works myself 😂 0.9.x just fixes svelte and adds astro parsing, but i want to close this ticket once we have a release working on open vsx. 0.10.0 will be a major improvement but I need til next week to do more thorough manual testing |
Is there an existing issue for this?
Current Behavior
Server crash with error:
Expected Behavior
Server starts without error
Steps To Reproduce
Simply install the latest v0.9.0 of "GraphQL: Language Feature Support" vscode extension.
Environment
Anything else?
Rollback on v0.8.25 => no error
The text was updated successfully, but these errors were encountered: