Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"last" on function connections without @sortable doesn't make sense? #713

Open
benjie opened this issue Feb 1, 2021 · 2 comments
Open

Comments

@benjie
Copy link
Member

benjie commented Feb 1, 2021

I think if you have a non-@sortable function that returns setof, you will always get an error if you pass a non-null value to last; therefore we really oughtn't expose last in the first place.

Alternatively we should fix it by using row_number(), but that could be expensive.

@benjie
Copy link
Member Author

benjie commented Sep 27, 2023

Note: the cursor connections spec requires that you support either forward or backward or both: https://relay.dev/graphql/connections.htm#sec-Arguments

So omitting backwards is allowed.

@benjie
Copy link
Member Author

benjie commented Feb 8, 2024

Marking this as high priority because it's a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🐭 Shrew
Development

No branches or pull requests

1 participant