Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since 5.3.1, possibility incorrect for US "+1 111 111 1111" #103

Open
minorbug opened this issue Jun 27, 2023 · 0 comments
Open

Since 5.3.1, possibility incorrect for US "+1 111 111 1111" #103

minorbug opened this issue Jun 27, 2023 · 0 comments

Comments

@minorbug
Copy link

minorbug commented Jun 27, 2023

Starting in 5.3.1, a US phone number of correct length (example: '+1 111 111 1111') returns "invalid" possibility. In 5.3.0, it correctly returns "is-possible". This is contrary to the readme, which states "quickly guesses whether a number is a possible phone number by using only the length information, much faster than a full validation". Also, in libphonenumber's source, the function only checks length for a given reason.

This affects all versions of awesome-phonenumber after 5.3.0.

5.3.0: https://js-cc6s3q.stackblitz.io
5.3.1: https://js-b8urus.stackblitz.io
libphonenumber demo page: https://htmlpreview.github.io/?https://github.com/google/libphonenumber/blob/master/javascript/i18n/phonenumbers/demo-compiled.html

@minorbug minorbug reopened this Jun 27, 2023
@minorbug minorbug changed the title Since 5.3.1, possibility incorrect for US "+11111111" Since 5.3.1, possibility incorrect for US "+1 111 111 1111" Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant