Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add "minimum power" option #455

Closed
PhillyPhoto opened this issue Oct 16, 2023 · 2 comments
Closed

[FR] Add "minimum power" option #455

PhillyPhoto opened this issue Oct 16, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@PhillyPhoto
Copy link

PLEASE NOTE THAT FEATURE REQUESTS ARE ONLY CONSIDERED AGAINST v.28.0+

Is your feature request related to a problem? Please describe.
We should be able to include the "--check-power" flag but have it automatically continue if the battery percentage is above a minimum amount (kind of like the free space check).

Describe the solution you'd like
Have a sub-function of --check-power (maybe something like "--min-power=40") that checks if the battery is at least a certain percent and will automatically continue even if the machine isn't plugged in. Their should probably be a hard lower limit that it won't allow the upgrade to run at (i.e. 20% battery).

Describe alternatives you've considered
N/A

Additional context
Knowledgeable users can disconnect the power once prompted for their credentials on ARM Macs and it will let them essentially cancel the upgrade from being pushed to their Macs. This has dragged out our deployment from completing.

@PhillyPhoto PhillyPhoto added the enhancement New feature or request label Oct 16, 2023
@grahampugh
Copy link
Owner

grahampugh commented Oct 16, 2023

It's not a bad idea, though I fear your knowledgeable users will always find a way. Sometimes these things are HR issues more than technical ones.

You could of course set the --power-wait-limit to a really long time.

@grahampugh
Copy link
Owner

This is addressed in v35.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants