-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move away from RegExp #206
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I like this package because it has no third party imports:
m3u8/go.mod
Lines 1 to 3 in 5abb127
but I noticed today the parsing is based on regular expression:
m3u8/reader.go
Line 25 in 5abb127
using this file:
I get this result:
so the RegExp option is using 4 times the memory, while the scanner option is double to triple the speed. its possible other options are better as well, the above implementation is just what I came up with.
The text was updated successfully, but these errors were encountered: