-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics-generator: add option to inject the tenant ID as metrics label #3630
Comments
3 tasks
3 tasks
PR has been merged and will be backported to 2.5. |
This is for Ring and they are running GET. The fix is in 2.5 rel being cut this week. The next GET build is 2 weeks out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Scenario:
Describe the solution you'd like
Tempo gets a configuration option to add the tenant ID as metric label to all generated metrics.
It would have to be a setting on the registry, something like:
Or maybe:
Describe alternatives you've considered
Workaround: inject an attribute on every span and configure these as
dimensions
in the service-graph and span-metrics processor. This could be done in the application or by the tracing pipeline.Downside: doing this in the instrumentation risks missing some spans --> these won't have a tenant ID and won't be counted.
Additional context
Implementation notes: we already inject a label in the registry
tempo/modules/generator/registry/registry.go
Lines 101 to 102 in d94e1f2
I think we just add some extra code here: if the config setting is active add another
externalLabel
which contains the value oftenant
.This will automatically add it to all metrics generated for that tenant.
The text was updated successfully, but these errors were encountered: