-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logcli: live tail does not work with https proxies #6499
Comments
Hi! This issue has been automatically marked as stale because it has not had any We use a stalebot among other tools to help manage the state of issues in this project. Stalebots are also emotionless and cruel and can close issues which are still very relevant. If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry. We regularly sort for closed issues which have a We may also:
We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task, |
please keep open |
Describe the bug
Followup issue as requested from: #6484 (review)
Support for connecting through http and https forward/CONNECT-style proxies was added to
logcli
in #6484 with the--proxy-url
flag. The current state is that both http:// and https:// proxies are supported for standard lookups. However when-t
(follow/tail) is used only http:// proxies work as expected. If an https:// proxy is used the websocket proxy code ingorilla/websocket
library will fail with:There are a couple open issues and PR about adding https proxy support to
gorilla/websocket
. One in particular that I have tested as working as expected withlogcli
is gorilla/websocket#740This can be swapped in by modifying
go.mod
:It is not clear when upstream gorilla/websocket will finish the work to bring in support for https proxies. It's apparent they intend to support this since there is some existing code in place, but it's not complete nor working yet.
To Reproduce
Steps to reproduce the behavior:
logcli
from this PR or later: logcli: add --proxy-url flag for http/https proxy support #6484Expected behavior
Tailing of logs should work as expected as if no
--proxy-url
was specified.Environment:
The text was updated successfully, but these errors were encountered: