Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics for GRPC streams do not correctly include tags when stream ends. #3745

Open
cchamplin opened this issue May 17, 2024 · 0 comments · May be fixed by #3746
Open

Metrics for GRPC streams do not correctly include tags when stream ends. #3745

cchamplin opened this issue May 17, 2024 · 0 comments · May be fixed by #3746
Assignees
Labels
awaiting user waiting for user to respond bug

Comments

@cchamplin
Copy link

Brief summary

When using GRPC streams in k6 when a stream is closed because of an error or normal execution a grpc_req_duration is emitted but it contains no information about the stream and it does not include custom tags provided when the stream was started.

k6 version

0.51.0

OS

Linux, MacOS

Docker version and image (if applicable)

No response

Steps to reproduce the problem

  1. Create a grpc stream, with custom tags
  2. Close the stream on the server
  3. Observe the grpc_req_duration metric does not include the url or method name, and does not include custom tags.

Expected behaviour

Custom tags and the method name would be included in the metric.

Actual behaviour

No custom tags or method name are included in the metric.

@cchamplin cchamplin added the bug label May 17, 2024
@joanlopez joanlopez assigned cchamplin and unassigned joanlopez May 27, 2024
@joanlopez joanlopez added awaiting user waiting for user to respond and removed triage labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting user waiting for user to respond bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants