remove the exception handler / improve logging out of the box (esp. when settings.DEBUG=True)

[olivierdalang]

Hi !

Out of the box, the package is very silent whenever issues happen.

It's not trivial to set logging correctly (it's not with native Django, and it's even less with possible not clearly defined interference between the native django settings.LOGGING and settings.DEBUG and their counterparts in settings.SAML2_AUTH).

In my case, after trying for over one hour to get output, I got rid of the exception handler and then only got a nice and clear trace indicating the exact issue (which was Cannot find ['xmlsec1']). From the issue tracker, it seem many people struggle in a similar way with uninformative error messages (Sorry, you are not allowed to access this app).

What about completely removing the exception handler when Django's settings.DEBUG=True, so that we get regular debug information ? Arguably even so when DEBUG=False, as I don't see a good reason for this package to provide some custom exception handling ?

Thanks !

For reference, here's a dirty monkey-patch to disable the exception handler (in your settings.py):

# monkey-patch out django_saml2_auth's exception handler to get proper traces
# https://github.com/grafana/django-saml2-auth/issues/275
if DEBUG:
    import django_saml2_auth.utils
    django_saml2_auth.utils.exception_handler = lambda func: func

[mostafa]

Hey @olivierdalang,

I think the root cause is correctly identified by @73VW in #277 and I fixed it in #281. I hope this help resolve the issue after I release a new version, which will happen very soon. In the meantime use the main branch to test the changes. I'd be happy to see this resolved.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.