-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP service should not abort the process on error #843
Comments
I think to implement it , maybe need to improve compoents controller 's runtime.. maybe we need to have a topology for our .. in the other way, do think it is proper way to extract http service to a standalone service?.. decouple with alloy main process. |
IMO this is tangentially related to #266, where the lifecycle of services are identical to the lifecycle of components This leads to two issues:
Could you explain what this would mean a little more? |
hello. I'm sorry for this mistake . at the time i see this issue, i have too little knowledge about alloy service model to understand this. but when i see the more alloy code ,and I know the service what's means in alloy .. and you're correct. when i see code, I found that the service is component in the alloy graph ? (maybe it called flow mode -- from grafana agent..) I will go to see the related issue to help me understand this problem deeply. thanks |
This code aborts the process on error:
alloy/internal/service/http/http.go
Lines 155 to 157 in dd1ccf6
While it's true that failing to start a service should eventually terminate the process, allowing services to abort the process directly can bypass cleanup logic scheduled by other running services or components.
To prevent future bugs, services should not directly terminate the Alloy process. Instead, the Alloy runtime should bubble up a service exiting prematurely so that Alloy gracefully shuts down when a service error is encountered.
The text was updated successfully, but these errors were encountered: