-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: gridcell ARIA role incorrectly added to Day button element #1688
Comments
@gpbl for what its worth, |
Waiting on a fix for this! |
Reason this is taking so long is because it is a breaking change: changing the HTML structure will likely break tests selectors and styles. I could finally make some progress with this in PR #2089 and will cut a mayor release for this fix. More details coming soon... thanks a lot for your patience! |
Discussed in #1674
Originally posted by rihardsgravis February 2, 2023
Bug description
The ARIA
gridcell
role is added to the Day button, but that is an incorrect role for the button since it does not represent a cell in a grid – it is in fact a child of a cell. Accessibility tests using the component are failing.Expected behaviour
The role for the button could be
button
or omitted at all since it's a HTM button component and the role for it is clear.The text was updated successfully, but these errors were encountered: