-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ad-blocker to chrome / chromium #872
Comments
I did try and come up with a PR for this today but unfortunately after some extensive research into chromedp and the way it currently implements headless mode does not support extensions. chromedevtools now have experimental support for that so we might want to either nudge the chromedp people to support this or wait for this to become stable. https://chromedevtools.github.io/devtools-protocol/tot/Extensions/ |
Thanks for the investigation @rhaist! |
I have an unconventional proposal to the following issue that might be true for a lot of users of
/convert/url
.Issue
When converting websites, blogs etc. that have a GDPR cookie banner they not always respect MediaType print and the resulting PDF contains an overlay with the cookie banner.
Proposal
Offer a gotenberg docker image where chrome/chromium includes an open source ad-blocker (e.g. ublock origin), getting rid of many potentially unwanted elements in the website that is about to be converted to a PDF.
References
Thorium is doing this with a special config file:
https://github.com/Alex313031/thorium/blob/590b88abe61be659e5e705d8d8cdf72c14cf24bf/infra/default_apps/external_extensions.json#L8
Information in the official chrome documentation:
https://developer.chrome.com/docs/extensions/how-to/distribute/install-extensions?hl=de#preference-linux
The text was updated successfully, but these errors were encountered: