-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow changing port via Environment Variables #620
Comments
Hello @pnutmath, I'm not against the idea, but do you have an exemple of a provider / infrastructure that does not allow the setting of a command flag? 😄 |
Our internal layer on top of Kubernetes does not support It would be helpful to support environment variables for port selection using the standard |
Currently, the application only allows changing the port number by passing a command-line parameter when launching the application. However, some users may not have access to this parameter switch, and as a result, they are unable to change the port number.
To make the application more flexible and accessible, I propose adding support for changing the port number via environment variables. This will enable users to specify the port number without having to pass command-line parameters.
The implementation of this feature will involve adding a new configuration option that checks for the value of an environment variable, and if present, uses it as the port number. If the environment variable is not set, the application will default to the current behavior of using the command-line parameter.
We believe this change will improve the usability and accessibility of the application for all users.
Suggested change:
Just setting default value
PORT
toapi-port-from-env
should workgotenberg/pkg/modules/api/api.go
Line 165 in 888f3fe
The text was updated successfully, but these errors were encountered: