-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] expose newConn function for custom Upgrader #914
Comments
(someone seems to have deleted their comments, so i have added back without mentioning them)
2 cases as to why: for api surfaces unrelated to net/http; for custom requirements/logic in conn upgrades. most things in Go provide New() as public api for handy usage of struct instantiation so not sure why that has to be secret private api here. |
ok seeking alternative ws then. theres no point pursuing here any further. |
Is there an existing feature request for this?
Is your feature request related to a problem? Please describe.
i was running into a situation where it required newConn() to be exposed. i needed to have a custom Upgrader. however the complexity of unexposed fields in newConn() made wiring it all up impossible.
is it possible to have it exposed as NewConn() or if not what would be the workaround? (previous issue #573)
Describe the solution that you would like.
renaming newConn() to NewConn()
Describe alternatives you have considered.
custom patch with
Anything else?
No response
The text was updated successfully, but these errors were encountered: