Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Unexpected delay for stopping player in SoundEditor #592

Closed
nighca opened this issue Jun 12, 2024 · 0 comments · Fixed by #596
Closed

UI: Unexpected delay for stopping player in SoundEditor #592

nighca opened this issue Jun 12, 2024 · 0 comments · Fixed by #596
Assignees
@ComfyFluffy

Comments

@nighca
Copy link
Collaborator

nighca commented Jun 12, 2024 •
edited
Loading

When stopping sound-play by click SoundPlayer in SoundEditor, there is a delay for SoundPlayer to update appearance

Image

As a comparison, there is no delay when do stopping in SoundsPanel
@ComfyFluffy ComfyFluffy linked a pull request Jun 14, 2024 that will close this issue
fix: delay on click to stop SoundPlayer #596
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ComfyFluffy ComfyFluffy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: delay on click to stop SoundPlayer ComfyFluffy/builder
2 participants
@nighca @ComfyFluffy