-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
window.define clashes with requirejs #43
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the widget manager is loaded, and window.define is available due to:
colab-cdn-widget-manager/src/amd.ts
Line 81 in 664b13d
RequireJS does an early exit: https://github.com/requirejs/requirejs/blob/898ff9e60eb6897500720151c0b488b8749fbe8d/require.js#L177
which means requirejs and require are undefined.
A few questions:
window.define
define this way what is its purpose?window.define
not be overwritten when it already exists?The answers to these questions will give us a better idea if widgetti/solara#292 is a correct fix or not.
Regards,
Maarten
The text was updated successfully, but these errors were encountered: