-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic integration with OpenTelemetry #786
Labels
api: logging
Issues related to the googleapis/nodejs-logging-winston API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Comments
domdomegg
added
priority: p3
Desirable enhancement or fix. May not be included in next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
labels
Mar 2, 2023
product-auto-label
bot
added
the
api: logging
Issues related to the googleapis/nodejs-logging-winston API.
label
Mar 2, 2023
losalex
added
priority: p2
Moderately-important priority. Fix may not be included in next release.
and removed
priority: p3
Desirable enhancement or fix. May not be included in next release.
labels
Jun 22, 2023
@dschnare Did you find any solutions ? I'm facing the same issue regarding the delay visible in the timestamps EDIT: I just found a solution when looking on the code of const date = new Date();
logger.info(`test log - ${date.toISOString()}`, {
[LoggingWinston.LOGGING_TRACE_KEY]: `projects/${'mod-glitch-dev'}/traces/${span.spanContext().traceId}`,
[LoggingWinston.LOGGING_SPAN_KEY]: span.spanContext().spanId,
timestamp: date
}); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: logging
Issues related to the googleapis/nodejs-logging-winston API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Is your feature request related to a problem? Please describe.
When setting up my tracing and logging following the Google Cloud documentation in the recommended way for Node.js, they don't appear to integrate with each other.
The docs recommend using OpenTelemetry for traces, and this seems to be a nice standards-based way to collect trace data:
@google-cloud/opentelemetry-cloud-trace-exporter
.Describe the solution you'd like
The logging library works out of the box with OpenTelemetry, set up in the way recommended by the Google Cloud documentation.
There's straightforward docs which guide the user on how to set up logging and tracing, such that logs go to Google Cloud Logging and traces go to Google Cloud Trace and they integrate with each other.
Additional context
OpenTelemetry was previously mentioned in #597, but I couldn't quite follow what that was requesting. The docs from the PR suggest one might have to override certain properties to get tracing working - this should work out of the box.
The text was updated successfully, but these errors were encountered: