Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: batch receipt modacks #10166

Closed
hongalex opened this issue May 14, 2024 · 0 comments · Fixed by #10234
Closed

pubsub: batch receipt modacks #10166

hongalex opened this issue May 14, 2024 · 0 comments · Fixed by #10234
Assignees
@hongalex
Labels
api: pubsub Issues related to the Pub/Sub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@hongalex
Copy link
Member

Receipt modacks are currently issued individually as messages arrive from the stream. In cases where there are a lot of small batches of messages, the library might issue a lot of modack RPCs. Batch these similar to the lease management ack/modacks/nacks so they're more efficient.
@hongalex hongalex added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: pubsub Issues related to the Pub/Sub API. labels May 14, 2024
@hongalex hongalex self-assigned this May 14, 2024
@hongalex hongalex mentioned this issue May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hongalex hongalex

Labels
api: pubsub Issues related to the Pub/Sub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pubsub): batch receipt modacks hongalex/google-cloud-go
1 participant
@hongalex