Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency in function's doc-string #1794

Open
jaindhairyahere opened this issue Jan 13, 2024 · 1 comment
Open

Inconsistency in function's doc-string #1794

jaindhairyahere opened this issue Jan 13, 2024 · 1 comment

Comments

@jaindhairyahere
Copy link

Description

Inconsistent function description at https://github.com/google/trax/blob/master/trax/layers/attention.py#L330C1-L342C23

The function states that it "Returns attention-computed per-head activations and unchanged mask." but returns only the activations.
@punitvara
Copy link

You are right. Can I raise PR to fix it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@punitvara @jaindhairyahere