Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file_wrapper allows invalid namespace names #88

Open
DemiMarie opened this issue Dec 25, 2021 · 1 comment
Open

file_wrapper allows invalid namespace names #88

DemiMarie opened this issue Dec 25, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@DemiMarie
Copy link
Contributor

The third argument should be checked to be a valid C++ identifier.
@happyCoder92
Copy link
Collaborator

This is quite minor as it's a build tool backing sapi_cc_embed_data rule.
Happy to accept PRs for that issue.

@cblichmann cblichmann added the enhancement New feature or request label Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cblichmann @happyCoder92 @DemiMarie