Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Support for tag commands: tagfocus, tagignore, tagshow, tagroot, etc #810

Open
NHDaly opened this issue Oct 20, 2023 · 1 comment
Open
Labels
Priority: p2 Buganizer priority - P2 type: feat Buganizer type - Feature Request

Comments

@NHDaly
Copy link
Contributor

NHDaly commented Oct 20, 2023

Branched from an existing issue:

I think some support for tags would be good. Ability to specify tagfocus and tagignore as an example.

Originally posted by @aalexand in #207 (comment)

It would be really nice to be able to filter this in the UI.
We're using DataDog's continuous profiling tool, which uses tags quite heavily, and it would be nice to be able to filter them in the downloaded profiles.

Similarly, we recently added threadid and task-id to Julialang profiles in JuliaPerf/PProf.jl#40, and it would be great to be able to filter by threadid and task id. (I'm going to add an option to set -tagroot automatically in PProf.jl, but even if it's not set it would still be nice to be able to filter, through the graph view.)

Thanks!

@NHDaly NHDaly changed the title UI Support for tag commands: tagfocus, tagignore, tagshow, etc UI Support for tag commands: tagfocus, tagignore, tagshow, tagroot, etc Oct 20, 2023
@NHDaly
Copy link
Contributor Author

NHDaly commented Oct 20, 2023

It would also be really nice to be able to adjust the -tagroot and -tagleaf in the UI, so that we can easily reorder the "threadid" and "task ID" since sometimes you'd want to group by threads to ask "what tasks were running on this thread" and sometimes you'd want to group by thread ID and you want to know what threads it ran on, and often you don't care about either and you just want to know what your server is doing overall.

@aalexand aalexand added type: feat Buganizer type - Feature Request Priority: p2 Buganizer priority - P2 labels Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: p2 Buganizer priority - P2 type: feat Buganizer type - Feature Request
Projects
None yet
Development

No branches or pull requests

2 participants