Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for javascript code #791

Open
Louis-Ye opened this issue Jul 28, 2023 · 3 comments
Open

Add tests for javascript code #791

Louis-Ye opened this issue Jul 28, 2023 · 3 comments
Assignees
Labels
Priority: p2 Buganizer priority - P2 type: feat Buganizer type - Feature Request

Comments

@Louis-Ye
Copy link
Collaborator

Per @ghemawat from #790:

None of the javascript in pprof is tested.

One alternative is that we might need to install node in some github action and use that (maybe something like https://github.com/browser-actions/examples).

Another alternative would be to do manually triggered tests: if pprof is invoked with a special flag, it passes that to the javascript, and the javascript code when it sees that flag runs self tests. But it would be better to figure out how to have real tests.

@Louis-Ye Louis-Ye added type: feat Buganizer type - Feature Request Priority: p3 Buganizer priority - P3 labels Jul 28, 2023
@Louis-Ye Louis-Ye added Priority: p2 Buganizer priority - P2 and removed Priority: p3 Buganizer priority - P3 labels Aug 11, 2023
@Louis-Ye
Copy link
Collaborator Author

#798 is addressing this issue.

@ghemawat
Copy link
Contributor

Should we leave this issue as open until we cover most of the Javascript code with tests (the current state just exercises one small part - the sorting of the Top table)?

@Louis-Ye Louis-Ye reopened this Aug 17, 2023
@aalexand
Copy link
Collaborator

Probably yes, we should keep it open - I would say at least until we have one happy-path test for each view and filtering feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: p2 Buganizer priority - P2 type: feat Buganizer type - Feature Request
Projects
None yet
Development

No branches or pull requests

3 participants