Support models lacking the "materials" property or primitive/material association #3279
Open
2 of 10 tasks
Comments
|
Thank you! A PR would be great, since you have the files to test. You may want to add a simple test case as well. We don't have much in the way of point cloud users, so I'm not surprised this is having some trouble. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
I have point cloud scans that yield models without any materials once converted to GLTF/GLB.
These models visually load, but then, break the code at a few places. This brought me to investigate further the situation.
As far as I can tell, I have encountered 2 situations where the code breaks with these unconventional files.
Case 1: File with no "materials" property in the GLTF
In
model-viewer/src/features/scene-graph/model.tsSuggestion: Don't use the
!syntax ingltf.materials!.entries()and do a null check insteadgltf.materials?.entries() ?? []Case 2: File with the "materials" property in the GLTF but no material associated in the mesh primitives
In
model-viewer/src/features/scene-graph/nodes/primitive-node.tsSuggestion: Simple null check
materialMappings?.materials != nullThis is another case where I seem to be the only one having to deal with bizarre GLTF structures 😆 . I will open a PR for this if that is ok with you guys.
Version
Browser Affected
OS
The text was updated successfully, but these errors were encountered: