How to pass additional # parameters to AR QuickLook when auto generating USDZ blob? #3425
Replies: 10 comments 13 replies
-
|
Good call. Currently the absence of |
Beta Was this translation helpful? Give feedback.
-
|
SceneViewer parameters include: enable_vertical_placement No apparent collisions. |
Beta Was this translation helpful? Give feedback.
-
|
Care to try a PR? |
Beta Was this translation helpful? Give feedback.
-
|
Erm... I wish I could. I don't know I have the chops for that... It'd be a learning curve. The main point to work on this would be here, right: |
Beta Was this translation helpful? Give feedback.
-
|
Correct - and learning is fun, right? 😁 Feel free to put up a draft PR if you need help with anything. The advantage of you taking point on this is that it'll get tested properly, and will also get done sooner (since I'm a bit underwater at the moment). Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
Heh. Very true. Ok. Let me try to take a swing at it. |
Beta Was this translation helpful? Give feedback.
-
|
i'm curious: has anyone used this approach to reproduce this kind of AR "buy button" with modelviewer's auto-generated USDZ?
(i'm wondering if this approach is a solution to #2708) |
Beta Was this translation helpful? Give feedback.
-
|
Yup. This is the solution you're looking for ;) |
Beta Was this translation helpful? Give feedback.
-
|
For future reference, this was addressed with #3434 |
Beta Was this translation helpful? Give feedback.
-
|
Hey everyone! Re-opening the discussion here, because as of today, it seems like opening an AR Quick Look session with an auto generated USDZ file from a blob is completely ignoring the hash, hence ignoring the parameters that are necessary to display a custom action button. You can try to open the third example (Mutliple QuickLook params) from this page: https://modelviewer-auto-usdz-params.glitch.me/ You should normally see a custom button in place of the "take picture" button. |
Beta Was this translation helpful? Give feedback.
-
|
I have the impression that just the ApplePay related hashes have been deprecated (by Apple last year). |
Beta Was this translation helpful? Give feedback.
-
|
Do you have a working example of using AR QuickLook with custum action button? On my side I can't get it to work really. |
Beta Was this translation helpful? Give feedback.
-
|
Sorry, noVon meinem iPhone gesendetAm 27.02.2024 um 17:30 schrieb Sov3rain ***@***.***>:
Do you have a working example of using AR QuickLook with custum action button? On my side I can't get it to work really.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
My post is based on experiences with the # parameters unrelated to to modelViewerVon meinem iPhone gesendetAm 27.02.2024 um 17:30 schrieb Sov3rain ***@***.***>:
Do you have a working example of using AR QuickLook with custum action button? On my side I can't get it to work really.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
The custom Action Button/Banner has a single function:It quits AR Quick Look but also emits an event message to the <a> tag it was launched from.Since modelviewer most often creates a blob and neither use a premade .usdz nor has an <a> tag to launch from, you'll find it hard to register a callback function to receive this event anyway.Am 27.02.2024 um 17:30 schrieb Sov3rain ***@***.***>:
Do you have a working example of using AR QuickLook with custum action button? On my side I can't get it to work really.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
Yeah, I know all of that. I need to be frank here, I'm not using model-viewer to launch AR, I'm using a custom component I wrote. But since the folks here are the only one trying to auto generate an USDZ and pass a blob to AR QuickLook I was hoping to have some enlightenment about the issue with not being able to add parameters to the blob's url. |
Beta Was this translation helpful? Give feedback.
-
|
I'd say this does indeed look like an iOS regression. I made a more versatile test suite here: You can turn on / off AutoUSDZ generation, various Quick Look params, and Scene Viewer params. See the ModelViewer src parameters it's generating below. Of particular note, I observe on iOS 17.4.1 that when AutoUSDZ is ON, and Apple Pay is ON, clicking through to view ARQL, no Apply Pay button is rendered. But, switching AutoUSDZ to OFF, and Apple Pay Button to ON, clicking through to view in ARQL does render the Apply Pay button. So when there is a 'hard' USDZ file, rather than a blob, it's still working. Also note that when AutoUSDZ is set to ON, and Custom Banner is set to ON, clicking through to view in ARQL does indeed show the custom banner. So you can still get custom banner interaction when using blob. I ran these tests on several iOS devices:
So it does indeed look like an iOS regression (rather than ModelViewer). If anyone has any other iOS version and could test, it would be interesting to know what version this became an issue. |
Beta Was this translation helpful? Give feedback.
-
|
thanks for this detective work! i think apple clearly wants us to all fork out for the headset...all of the AR features are just going to start breaking left and right until we strap that stupid thing to our faces ; ) |
Beta Was this translation helpful? Give feedback.
-
|
@milesgreen as of iOS 17.5 I can't seem to get any of the combinations to show any kind of overlay on iOS. Is it the same for you? |
Beta Was this translation helpful? Give feedback.
-
|
Dear Miles,
Would you mind to repeat this as a bug/regression report at https://bugs.webkit.org/ ?
Great work, BTW !!
Thomas Kumlehn
***@***.***
… Am 25.03.2024 um 23:37 schrieb Miles Green ***@***.***>:
@Sov3rain <https://github.com/Sov3rain>
I'd say this does indeed look like an iOS regression.
I made a more versatile test suite here:
https://modelviewer-extended-params.glitch.me/
You can turn on / off AutoUSDZ generation, various Quick Look params, and Scene Viewer params. See the ModelViewer src parameters it's generating below.
Of particular note, I observe on iOS 17.4.1 that when AutoUSDZ is ON, and Apple Pay is ON, clicking through to view ARQL, no Apply Pay button is rendered.
But, switching AutoUSDZ to OFF, and Apple Pay Button to ON, clicking through to view in ARQL does render the Apply Pay button. So when there is a 'hard' USDZ file, rather than a blob, it's still working.
Also note that when AutoUSDZ is set to ON, and Custom Banner is set to ON, clicking through to view in ARQL does indeed show the custom banner. So you can still get customer banner interaction when using blob.
I also ran these tests on an old iOS 15.8.1 device, and when AutoUSDZ is ON, and Apple Pay Button is ON, clicking through to view ARQL, does render the standard Apply Pay button. So it did used to work fine.
So it does indeed look like a regression.
If anyone has any other iOS version and could test, it would be interesting to know what version this became an issue.
—
Reply to this email directly, view it on GitHub <#3425 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAR6X7M6CYQGKGHL5VCAETY2CRMFAVCNFSM5VGBHOZKU5DIOJSWCZC7NNSXTOKENFZWG5LTONUW63SDN5WW2ZLOOQ5TQOJQHA2DCOA>.
You are receiving this because you commented.
|
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Thank you
… Am 26.03.2024 um 12:05 schrieb Miles Green ***@***.***>:
Done:
https://bugs.webkit.org/show_bug.cgi?id=271701
—
Reply to this email directly, view it on GitHub <#3425 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAR6X3KL3OKU5LXY26LQ73Y2FB5FAVCNFSM5VGBHOZKU5DIOJSWCZC7NNSXTOKENFZWG5LTONUW63SDN5WW2ZLOOQ5TQOJRGM4DKMA>.
You are receiving this because you commented.
|
Beta Was this translation helpful? Give feedback.
-
With upcoming iOS fixes (#3300) it's going to be possible to properly pass # parameters to AR QuickLook when auto generating USDZ blob.
Indeed, in Safari iOS 15.5 beta 4, when setting ModelViewer to fixed scaling, this now works, as the #allowsContentScaling=0 parameter is appended to the blob url and works correctly.
So, how might we be able to pass in other QuickLook parameters when auto generating USDZ?
When we have a full USDZ file path, we can append any number of QuickLook parameters to the URL in
ios-src.But when generating USDZ, there is no file path or
ios-src, and so no place to provide these additional parameters.Understanding not wanting to pollute ModelViewer with QuickLook-specific parameters.
Maybe one solution would be to allow
ios-srcto be set as just a url # fragment of one or more QuickLook parameters?Or is there another / better way?
Beta Was this translation helpful? Give feedback.
All reactions