-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attend_dtype
not used
#531
Comments
yes weird. @khatwanimohit can you take a look? I'm not sure what this is meant to represent? And the upstream flag is also kind of weird given that it is orphaned? maxtext/MaxText/layers/models.py Line 341 in 5353a95
I think we should figure out if We should make the code consistent and as simple as possible. Also, why is our pylint/pytype not raising alarms on this, unused vars are bad? |
Here it seems that the hard-coded
bfloat16
is used instead ofattend_dtype
. Alsoquery
is not cast. I guess the correct behavior should be casting bothquery
andself.embedding
toattend_dtype
?The text was updated successfully, but these errors were encountered: