Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode array of floats as binary container #17

Open
corecode opened this issue Aug 5, 2020 · 5 comments
Open

encode array of floats as binary container #17

corecode opened this issue Aug 5, 2020 · 5 comments

Comments

@corecode
Copy link

corecode commented Aug 5, 2020

Is there a reason why arrays of floating point numbers are not being encoded in a binary container?

@eieio
Copy link
Collaborator

eieio commented Aug 7, 2020

No reason other than there isn't a specialization to handle it, like there is for integral types.

I think it makes sense to use the binary container encoding for floating point arrays.

@corecode
Copy link
Author

corecode commented Aug 7, 2020

It seems like e.g. the vector specialization just needs to be changed from EnableIfIntegral to EnableIfArithmetic?

@eieio
Copy link
Collaborator

eieio commented Aug 13, 2020

That would work, but there might be users with data in the current encoding. It would be safer to add a separate specialization that can handle reading both encodings.

@corecode
Copy link
Author

corecode commented Aug 14, 2020 via email

@eieio
Copy link
Collaborator

eieio commented Aug 21, 2020

I'll look into it when I get a chance. I'm thinking of starting to maintain versioned releases to handle format breaking changes. Once I work that out I'll put up a point release with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants