New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo.ID is int64, but several consumers are int #2804
Comments
I believe we need to standardize on 64 bits for all IDs. The real problem is if GitHub ever uses a repo ID that doesn't fit in a 32 bit integer, and should not affect which architecture this code is running on, so I believe this is a very low priority issue. That is, unless you can show me otherwise. |
You're right that if the repo ID is over 32-bits there can be a problem. I'm not sure how large the IDs are. An |
In the v53.0.0 release, the Repository.ID is defined as an
int64
, but there are several consumers are presently defined asint
.For most users this isn't a huge problem, but if you're running on a 32 bit system it will be an issue & also requires an explicit cast when one shouldn't be needed.
Affected methods:
The text was updated successfully, but these errors were encountered: