Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In MultiHeadAttention, let num_heads=1 by default #3833

Open
carlosgmartin opened this issue Apr 8, 2024 · 0 comments
Open

In MultiHeadAttention, let num_heads=1 by default #3833

carlosgmartin opened this issue Apr 8, 2024 · 0 comments
Labels
Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment.

Comments

@carlosgmartin
Copy link
Contributor

Minor suggestion: In nn.MultiHeadAttention, let num_heads=1 by default, which yields single-head attention. This seems like the most natural default value. I can submit a PR for this.
@chiamp chiamp added the Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment. label Apr 10, 2024
@carlosgmartin carlosgmartin mentioned this issue Apr 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlosgmartin @chiamp