Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Specify location of ~/.docker/config.json #111

Open
pcj opened this issue Sep 25, 2018 · 0 comments
Open

Specify location of ~/.docker/config.json #111

pcj opened this issue Sep 25, 2018 · 0 comments

Comments

@pcj
Copy link
Contributor

pcj commented Sep 25, 2018

The docker CLI has a --config flag that allows one to specify an alternate location for the docker config directory. I am primarily interested in implementing push/pull basic auth support in rules_docker bazelbuild/rules_docker#526 and would benefit from such functionality here.

As the pusher.par already has a --config flag for a different purpose, I am proposing a flag named --client_config or similar to configure the directory where the config.json file is. This new feature would largely affect https://github.com/google/containerregistry/blob/master/client/docker_creds_.py#L222-L228.

Any objections to this? Working on a PR now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant