-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A silent failure occurs if a file path listed in filePushOrder
does not exist
#984
Comments
I think this could be a warning, rather than an error that cancels the push and raises the exit code. If the file is no longer part of the project, that suggests it's not needed anymore. |
Could be, sure. But on the other hand, there’s the case of typos. In my case, I was trying to fix an intermittent problem with a program that seemed to be caused by race conditions in code loading. I thought it might help to have a certain file pushed first, before all the rest. So I added this key to the config file and pushed, and… no change. Weeks later I double checked and realized I had a missing character in the file name, the result of a typo. So my attempted fix had never actually taken effect, and since Personally I prefer tools to fail fast and fail loudly, any time they cannot accomplish exactly what I’ve asked them to do. |
Expected Behavior
If a file path listed in
filePushOrder
does not exist, I would expectclasp push
to fail with a clear error message.Actual Behavior
It just skips the missing file and continues as if nothing went wrong.
Steps to Reproduce the Problem
filePushOrder
clasp push
echo $?
clasp push
is0
but should have been non-zero.Specifications
node -v
):v20.8.1
clasp -v
):2.4.2
The text was updated successfully, but these errors were encountered: