Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ctclient command-line tool #900

Open
1 of 3 tasks
pav-kv opened this issue Apr 7, 2022 · 0 comments
Open
1 of 3 tasks

Refactor ctclient command-line tool #900

pav-kv opened this issue Apr 7, 2022 · 0 comments

Comments

@pav-kv
Copy link
Contributor

pav-kv commented Apr 7, 2022 •
edited

@pav-kv pav-kv self-assigned this Apr 7, 2022
@pav-kv pav-kv mentioned this issue Apr 7, 2022
Merged
2 tasks
@pav-kv pav-kv mentioned this issue May 9, 2022
Merged
mhutchinson added a commit that referenced this issue May 10, 2022
@mhutchinson
ctclient fails if any unexpected arguments are found (#926)
81944ab 
All of the parameterization to the subcommands is performed by flags. However, as the subcommands themselves are selected via normal arguments (no hyphens), this can lead to newcomers (e.g. me) believing that the log to fetch from could also be a bare argument. On something like get-entries, there was no way to know that the logname was ignored. Now, this will explode and the user gets the option to reconsider how they are specifying the parameters.

e.g. `go run github.com/google/certificate-transparency-go/client/ctclient@master get-entries submariner --first 35494500 --last 35494590` looks very reasonable and returns data, but it isn't from submariner.

#900
@pav-kv pav-kv removed their assignment Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pav-kv