Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinDiff displays blocks as 100% similar even though instruction operands differ #12

Open
cblichmann opened this issue Sep 21, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@cblichmann
Copy link
Member

BinDiff doesn't detect a change between:

movups      b16 ds:[r8+rcx-16], b16 xmm0

and

movups      b16 ds:[r8+rcx+0x18], b16 xmm0

Ideally, the matched basic block should be "yellow" instead of "green":

69532690__16060079__68576

@cblichmann
Copy link
Member Author

Possible implementation note: We can add an additional pass (after the main diffing run) to annotate these instruction level changes. This can even be trivially parallelized: As these are per instruction and hence also per basic block changes that won't influence control flow diffing.

@cblichmann cblichmann added the enhancement New feature or request label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant