Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual matching does not trigger diff #10

Open
cblichmann opened this issue Sep 21, 2023 · 1 comment
Open

Manual matching does not trigger diff #10

cblichmann opened this issue Sep 21, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@cblichmann
Copy link
Member

Steps to reproduce the problem:

  1. Unmatch blocks.
  2. Match blocks.
  3. Observe that all text is different. See gif and image.

What is the expected behavior?
Text is diffed properly.

What went wrong?
Text is marked as different.

What version of the product are you using? On what operating system?
BinDiff 6, Win10.

177788191__32168413__191454

177788191__32168414__191454

Ported from b/177788191

@cblichmann cblichmann added the enhancement New feature or request label Sep 21, 2023
@cblichmann
Copy link
Member Author

This is a shortcoming of the UI. Ideally, the action shown in your video would trigger a re-diff of the function in question. But since we only have a one-way communication between the UI and the BinDiff engine, all the UI does is kind of a best-effort match/unmatch.

The actual textual diff is correct in a way, as the addresses are different on both sides. But I agree that we can to better here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant