-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual matching does not trigger diff #10
Labels
enhancement
New feature or request
Comments
This is a shortcoming of the UI. Ideally, the action shown in your video would trigger a re-diff of the function in question. But since we only have a one-way communication between the UI and the BinDiff engine, all the UI does is kind of a best-effort match/unmatch. The actual textual diff is correct in a way, as the addresses are different on both sides. But I agree that we can to better here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce the problem:
What is the expected behavior?
Text is diffed properly.
What went wrong?
Text is marked as different.
What version of the product are you using? On what operating system?
BinDiff 6, Win10.
Ported from b/177788191
The text was updated successfully, but these errors were encountered: