Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#cfg in macros #128

Open
kaczmarczyck opened this issue Jul 8, 2020 · 2 comments
Open

#cfg in macros #128

kaczmarczyck opened this issue Jul 8, 2020 · 2 comments
Assignees
@gendx @kaczmarczyck
Labels
enhancement New feature or request

Comments

@kaczmarczyck
Copy link
Collaborator

As noted in #127 , we should support #cfg inside macro calls, i.e. cbor_map.
@kaczmarczyck kaczmarczyck added the enhancement New feature or request label Jul 8, 2020
@kaczmarczyck kaczmarczyck mentioned this issue Jul 8, 2020
Merged
2 tasks
@gendx
Copy link
Collaborator

gendx commented Jul 9, 2020

See the register_structs! macro of Tock. It should boil down to matching $(#[$attr:meta])* before each item that can be #cfged.

@kaczmarczyck
Copy link
Collaborator Author

I'll mention this here since it is related:
rust-lang/rust#73663

It should be orthogonal though if we don't support #cfg in macros so far.

This was referenced Jan 6, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gendx gendx

@kaczmarczyck kaczmarczyck

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove CTAP 2.1 flag kaczmarczyck/OpenSK
2 participants
@gendx @kaczmarczyck