Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster attributes subscription methods #100

Open
edWin-m opened this issue Mar 14, 2023 · 1 comment
Open

Cluster attributes subscription methods #100

edWin-m opened this issue Mar 14, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@edWin-m
Copy link
Contributor

edWin-m commented Mar 14, 2023

@pierredelisle I have noticed that each cluster has its subscription method that we can leverage to get the changes for attributes in that cluster. For instance, the OnOffCluster has the subscribeOnOffAttribute method.

public void subscribeOnOffAttribute(BooleanAttributeCallback callback, int minInterval, int maxInterval) {...}

Could you please tell me why is the GHSAFM not using this function, but instead using the subscribeToPath in ChipDeviceController?

public void subscribeToPath(SubscriptionEstablishedCallback subscriptionEstablishedCallback, ResubscriptionAttemptCallback resubscriptionAttemptCallback, ReportCallback reportCallback, long devicePtr, List<ChipAttributePath> attributePaths, List<ChipEventPath> eventPaths, int minInterval, int maxInterval, boolean keepSubscriptions, boolean isFabricFiltered) {...}
@pierredelisle
Copy link
Contributor

Indeed! As for the reason, sheer ignorance :-). Will look into it shortly...

@pierredelisle pierredelisle added the enhancement New feature or request label Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants